Store creation M2: WPCOM plan screen (UI only) #8120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
You can test the changes from this Pull Request by:
|
selanthiraiyan
approved these changes
Nov 15, 2022
Comment on lines
115
to
127
| // Plan features. | ||
| VStack(alignment: .leading, spacing: 16) { | ||
| ForEach(viewModel.features, id: \.title) { feature in | ||
| HStack(spacing: 12) { | ||
| Image(uiImage: feature.icon) | ||
| .renderingMode(.template) | ||
| .foregroundColor(Color(.wooCommercePurple(.shade90))) | ||
| Text(feature.title) | ||
| .foregroundColor(Color(.label)) | ||
| .bodyStyle() | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Nit: What do you think about breaking the body down into smaller views? For example, this part can be a separate featuresListView View.
8 tasks
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8108
Description
This PR implemented the WPCOM eCommerce plan screen with a CTA to purchase the plan. The integration with IAP will be in a separate PR, since the testing steps are more complicated. There are two things that I'm clarifying with Ann in the design: HyVloP5FipZzyPVenH2euI-fi-2369%3A102723&t=Y9fAyMRWXAyQSWDn-0
In the SwiftUI view, there are too many one-off styles (spacing/color) so I only put some shared styles in the
Layoutenum. If you know of a better way to organize these elements, please feel free to suggest anything.Testing instructions
You can just check out the UI in SwiftUI preview in Xcode. To test this in the app, this screen requires a WPCOM plan product which would be easier to test once it's integrated with IAP.
Screenshots
RELEASE-NOTES.txtif necessary.